refactor: move Story and Series UI-bus listeners off Agent Mode - #55
Merged
Conversation
The four product-slice listeners now import lib/uiBus. agentUiBus reexports that module so Agent Mode internals stay stable. SLICE_AGENT_IMPORT_ALLOWLIST is empty.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ce8bf90. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
PR pequeño Codex: mover los 4 listeners de agentUiBus a superficie neutral.
Incluye canciones alternativas (y Studio/SFX) si aún no están en
main. Mezclar este PR en main, no en una rama apilada.SeriesEpisodePanel,SeriesLabPanel,SeriesReviewPanelyStoryLabPanelimportanlib/uiBus.features/agent/agentUiBus.tsreexporta.SLICE_AGENT_IMPORT_ALLOWLISTqueda vacía.Gates locales en esta rama:
useStore.setStateagent 0, slice→agent 0, legacy 0.Dueño del merge: humano. No mezclar #48. Paso 3 no se declara cerrado hasta que
maintenga esos tres ceros y revisión humana.Note
Medium Risk
Touches generation queueing, Hunyuan3D jobs, and videoclip FFmpeg mounts across two execution paths; behavior should be equivalent but regressions in Studio prep or alternative-song flow would be user-visible.
Overview
This PR centralizes agent side effects behind
applicationAdaptersso the legacyexecuteAgentActionsrunner and the capability registry share the same paths, and product slices no longer depend onfeatures/agent.Studio and videoclips logic moves out of
agentActions.ts,studioGuidance.ts, andalternativeSongActions.tsintofeatures/studioandfeatures/videoclips(commands→actionsreturningCommandResult→ thinadapters). TheStudioAdaptergainsprepareVideo/prepareImage/prepareAudio/prepare3d,startGeneration, references, LoRAs, and SFX pack; a newVideoclipAdapterhandles attach/mount alternative songs with execution reuse on mount.studioCapabilitiesdrops the lazyagentActionsbridge and callscontext.adapters.studio.*directly.UI bus implementation relocates to
lib/uiBus.ts;agentUiBusre-exports it. Story/Series lab panels import../../lib/uiBusinstead of the agent module.Contract tests update expectations: no feature slice → agent imports, zero legacy capability executors (all 73 go through adapters), and
createDefaultApplicationAdaptersincludesvideoclips.Reviewed by Cursor Bugbot for commit ce8bf90. Configure here.